Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include direct member flag in total group query #562

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

andre-code
Copy link
Contributor

PR to fix the total groups value, now including the flag for direct members when provided.

/deploy

@RenkuBot
Copy link
Contributor

RenkuBot commented Dec 3, 2024

You can access the deployment of this PR at https://renku-ci-ds-562.dev.renku.ch

@coveralls
Copy link

coveralls commented Dec 3, 2024

Pull Request Test Coverage Report for Build 12284978228

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 86.377%

Files with Coverage Reduction New Missed Lines %
components/renku_data_services/crc/blueprints.py 1 93.06%
components/renku_data_services/crc/models.py 1 84.71%
components/renku_data_services/storage/blueprints.py 2 95.69%
components/renku_data_services/storage/models.py 2 84.11%
Totals Coverage Status
Change from base Build 12281701063: -0.02%
Covered Lines: 14628
Relevant Lines: 16935

💛 - Coveralls

@andre-code andre-code marked this pull request as ready for review December 3, 2024 12:15
@andre-code andre-code requested a review from a team as a code owner December 3, 2024 12:15
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leafty
Copy link
Member

leafty commented Dec 11, 2024

@andre-code any reason this is not merged yet?

@andre-code andre-code merged commit 9cb5d81 into main Dec 12, 2024
17 checks passed
@andre-code andre-code deleted the andrea/fix-total-groups-in-all-group branch December 12, 2024 08:47
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants